Andreas is out this week. Toon, can you take a look?
LGTM except for the test change.
This is good stuff.
https://codereview.chromium.org/342453002/diff/20001/test/mjsunit/es6/arguments-iterator.js
File test/mjsunit/es6/arguments-iterator.js (right):
https://codereview.chromium.org/342453002/diff/20001/test/mjsunit/es6/arguments-iterator.js#newcode11
test/mjsunit/es6/arguments-iterator.js:11:
assertTrue(arguments.hasOwnProperty(Symbol.iterator));
Can you change this to?
var descr = Object.getOwnPropertyDescriptor(arguments, Symbol.iterator);
assertTrue(descr.writable);
assertTrue(descr.configurable);
assertFalse(descr.enumerable);
assertEquals(Array.prototype.values, descr.value);
The current test does not cover whether this is a data property or an
accessor.
https://codereview.chromium.org/342453002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
