https://codereview.chromium.org/342453002/diff/40001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/342453002/diff/40001/src/accessors.cc#newcode184
src/accessors.cc:184: MaybeHandle<Object> maybe =
Object::SetDataProperty(&it, value);
On 2014/08/18 13:47:25, Toon Verwaest wrote:
This doesn't seem right to me, if only because the setter could have
been called
through a derived dictionary-mode object for which the iterator will
stop on the
dictionary mode object; and HasProperty will be false.

What's the expected behavior exactly? Can't you just use
SetProperty(&it,
value), or SetOwnPropertyIgnoreAttributes?

The intent is to replace the existing interceptor with a plain old data
property.

https://codereview.chromium.org/342453002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to