https://codereview.chromium.org/342453002/diff/70008/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/342453002/diff/70008/src/accessors.cc#newcode180
src/accessors.cc:180: LookupIterator it(object,
Utils::OpenHandle(*name));
On 2014/08/22 11:01:02, Toon Verwaest wrote:
What about just
if (SetPropertyOnInstanceIfInherited(isolate, info, name, value)) {
return;
}
LookupIterator it(object, name);
CHECK(it.HasProperty());
DCHECK(it.HolderisReceiverOrHiddenPrototype());
Object::SetDataProperty(&it, value);
Done, works fine; thanks for the tip. The difference is that setting
the property on a frozen object doesn't throw, because of the
strict-mode thing. I changed the test case accordingly. WDYT?
https://codereview.chromium.org/342453002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
