https://codereview.chromium.org/470593002/diff/20001/src/compiler/instruction-selector-impl.h
File src/compiler/instruction-selector-impl.h (right):
https://codereview.chromium.org/470593002/diff/20001/src/compiler/instruction-selector-impl.h#newcode204
src/compiler/instruction-selector-impl.h:204: if ((location.rep_ &
rMask) == rFloat64) {
On 2014/08/13 15:40:05, Michael Starzinger wrote:
nit: Can we use RepresentationOf here?
Done.
https://codereview.chromium.org/470593002/diff/20001/src/compiler/machine-type.h
File src/compiler/machine-type.h (right):
https://codereview.chromium.org/470593002/diff/20001/src/compiler/machine-type.h#newcode92
src/compiler/machine-type.h:92: // Gets the element size of the machine
type.
On 2014/08/13 15:40:05, Michael Starzinger wrote:
nit: [...] size in bytes of [...]
Done.
https://codereview.chromium.org/470593002/diff/20001/test/cctest/compiler/codegen-tester.h
File test/cctest/compiler/codegen-tester.h (right):
https://codereview.chromium.org/470593002/diff/20001/test/cctest/compiler/codegen-tester.h#newcode210
test/cctest/compiler/codegen-tester.h:210: // return an int value.
On 2014/08/13 15:40:05, Michael Starzinger wrote:
nit: s/int/uint/ (twice).
Done.
https://codereview.chromium.org/470593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
