NOT LGTM because of obvious violation of the style guide.
And why can't we use the type system instead? The MachineType+RepType looks
like
a subset of the existing type functionality, unless I'm missing something.
So
what's the point of this CL?
https://codereview.chromium.org/470593002/diff/20001/test/cctest/compiler/test-run-machops.cc
File test/cctest/compiler/test-run-machops.cc (right):
https://codereview.chromium.org/470593002/diff/20001/test/cctest/compiler/test-run-machops.cc#newcode14
test/cctest/compiler/test-run-machops.cc:14: #define CHECK_UINT32_EQ(x,
y) \
CheckEqualsHelper for unsigned.
https://codereview.chromium.org/470593002/diff/60001/src/compiler/machine-type.h
File src/compiler/machine-type.h (right):
https://codereview.chromium.org/470593002/diff/60001/src/compiler/machine-type.h#newcode19
src/compiler/machine-type.h:19: rBit = 1 << 0,
Urghs, WTF? Revival of the hungarian notation? Can we please just follow
the decision to adopt the C++ style guide instead of adding just another
custom naming scheme?
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Constant_Names
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Enumerator_Names
https://codereview.chromium.org/470593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
