LGTM if the src/v8.h issue is addressed.
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h
File src/compiler/machine-type.h (right):
https://codereview.chromium.org/470593002/diff/80001/src/compiler/machine-type.h#newcode9
src/compiler/machine-type.h:9: #include "src/v8.h"
On 2014/08/14 08:26:46, titzer wrote:
On 2014/08/14 07:57:01, Benedikt Meurer wrote:
> Same for "src/v8.h". Include what you need instead to avoid further
slowing
down
> compilation.
It needs kPointerSize to define the kMachPtr type.
Then include "src/globals.h" which defines it.
https://codereview.chromium.org/470593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
