On 2014/08/14 at 18:31:07, Benedikt Meurer wrote:
>
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc#newcode85
> test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc:85:
TEST_P(LogicalTest, Parameter) {
> My understanding was that the name will be concatenated with the first
parameter of INSTANTIATE_TEST_CASE_P, so here InstructionSelectorTest. If I
run
compiler-unittest, those tests are currently listed as
InstructionSelectorTest/LogicalTest.Parameter and using
--gtest_filter='InstructionSelector*' will find them.
>
> Have I misunderstood?
Ah right, of course. Sorry, I confused myself :-)
Ahem, still my first statement was correct. The class name will be composed
of
LogicalTest and Parameter, which may not be unique among all tests in
compiler-unittests. So better add the InstructionSelector prefix here as
well.
https://codereview.chromium.org/475823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
