Ok, I've looked into this again, and I think you are right. We can avoid the
possible name collision using an anonymous namespace, i.e.
namespace {
class MyTest : public InstructionSelectorTestWithParam<ParamType> {};
TEST_P(MyTest, A) {...}
TEST_P(MyTest, B) {...}
}
INSTANTIATE_TEST_CASE_P(InstructionSelectorTest, MyTest,
::testing::Values(...));
I really like this solution (shortens the test names), and I'll apply that
to
the ARM instruction selector unittest.
https://codereview.chromium.org/475823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
