https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
File
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
(right):
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc#newcode82
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc:82:
typedef InstructionSelectorTestWithParam<DPI> LogicalTest;
On 2014/08/14 17:58:31, Benedikt Meurer wrote:
s/LogicalTest/InstructionSelectorLogicalTest/
See below for an explanation.
Done.
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc#newcode85
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc:85:
TEST_P(LogicalTest, Parameter) {
On 2014/08/14 17:58:31, Benedikt Meurer wrote:
Test names must be globally unique, so please always add the
InstructionSelector
prefix to the test case name, i.e. InstructionSelectorLogicalTest.
This has the additional advantage that one can run all
InstructionSelector tests
by using --gtest_filter=InstructionSelector* with the
compiler-unittests binary.
Acknowledged.
https://codereview.chromium.org/475823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
