https://codereview.chromium.org/553413002/diff/20001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/553413002/diff/20001/src/array.js#newcode1139
src/array.js:1139: if (!IS_NULL_OR_UNDEFINED(receiver) &&
Can this test be moved out of the loop?
https://codereview.chromium.org/553413002/diff/20001/src/array.js#newcode1175
src/array.js:1175: if (!IS_NULL_OR_UNDEFINED(receiver) &&
Maybe we can introduce a helper function/macro for this?
SHOULD_CREATE_WRAPPER(receiver, f)
https://codereview.chromium.org/553413002/diff/20001/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/553413002/diff/20001/src/collection.js#newcode118
src/collection.js:118: if (!IS_NULL_OR_UNDEFINED(receiver)) {
Why is this one different? Can you verify with the spec and add a test
that hilights the difference if the spec requires a different semantic?
https://codereview.chromium.org/553413002/diff/20001/test/mjsunit/array-iteration.js
File test/mjsunit/array-iteration.js (right):
https://codereview.chromium.org/553413002/diff/20001/test/mjsunit/array-iteration.js#newcode72
test/mjsunit/array-iteration.js:72: a = new Array();
nit
a = [];
https://codereview.chromium.org/553413002/diff/20001/test/mjsunit/array-iteration.js#newcode73
test/mjsunit/array-iteration.js:73: [1,2].filter(function() {
a.push(this) }, "");
nit, space after comma
https://codereview.chromium.org/553413002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
