https://codereview.chromium.org/553413002/diff/20001/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/553413002/diff/20001/src/collection.js#newcode268
src/collection.js:268: if (!IS_NULL_OR_UNDEFINED(receiver)) {
Same comment here as Erik's comment above.
https://codereview.chromium.org/553413002/diff/20001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/553413002/diff/20001/src/harmony-array.js#newcode36
src/harmony-array.js:36: var new_thisArg = thisArg;
Call it "receiver", or something that doesn't have this_awfulStyle :)
Same comments about factoring out the test to some kind of macro.
https://codereview.chromium.org/553413002/diff/20001/test/mjsunit/array-iteration.js
File test/mjsunit/array-iteration.js (right):
https://codereview.chromium.org/553413002/diff/20001/test/mjsunit/array-iteration.js#newcode76
test/mjsunit/array-iteration.js:76: // Do not create a new object in
each function call when receiver is a primitive value.
"when receiver is not a primitive value" here, and below
https://codereview.chromium.org/553413002/diff/20001/test/mjsunit/harmony/array-find.js
File test/mjsunit/harmony/array-find.js (right):
https://codereview.chromium.org/553413002/diff/20001/test/mjsunit/harmony/array-find.js#newcode246
test/mjsunit/harmony/array-find.js:246: // Do not create a new object in
each function call when receiver is a primitive value.
80 column limit.
https://codereview.chromium.org/553413002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
