On 2014/09/23 10:31:28, Yang wrote:
On 2014/09/23 06:13:35, Jens Widell wrote:
> On 2014/09/22 15:26:31, Yang wrote:
> > On 2014/09/19 15:32:29, Jens Widell wrote:
> > > PTAL
> > >
> > > The change in https://codereview.chromium.org/576323004/ caused a
Blink
> layout
> > > test to start failing due to an exception message being reported as
having
> > been
> > > thrown on a different (more correct) line. This patch causes the
same
change
> > in
> > > behavior as that Blink patch.
> >
> > LGTM. Will land after I run a couple of tests.
>
> Thanks!
>
> Beware that this patch could cause more test failures similar to what I
> encountered in https://codereview.chromium.org/576323004/, and thus
might be
> tricky to land. I'm not aware of any other cases where the changed
behaviour
> affects a test, though. I'd of course be happy to help out on the Blink
side
if
> this patch does cause any kind of issues.
I ran webkit layout tests and found the following two test failures:
inspector/sources/debugger/rethrow-error-from-bindings-crash.html
storage/websql/sql-error-codes.html
It would be great to make sure those are just wrong expectations. We could
then
mark them as NEEDS_MANUAL_REBASELINE before landing it to V8 and then
after V8
has been rolled, rebaseline.
The sql-error-codes.html test should be fixed with
https://codereview.chromium.org/576323004/ which landed (in Blink) an hour
ago.
I'll investigate rethrow-error-from-bindings-crash.html, but since that's a
test
specifically about rethrowing errors, it seems likely they trigger code that
does that, and thus would be (correctly) affected by this fix.
https://codereview.chromium.org/587703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
