On 2014/09/23 12:13:17, Jens Widell wrote:
This CL works around the test failure:
https://codereview.chromium.org/592293003/
Note though that the way it does that is by completely eliminating the
v8::TryCatch::ReThrow() usage that the test is supposed to be testing in
the
first place, so we should probably not be happy with just that.
Note also that the CL is not just a workaround; it's the right thing to
do and
would have been done eventually either way.
Not sure I'm following. If I understand correctly, calling Debug::OnThrow
somehow clears the pending message, and with this CL, we end up with no
message
at the end, hence test failure.
How does https://codereview.chromium.org/592293003/ fix this issue?
In any case, I guess it would be fine to land this once the work around
lands?
https://codereview.chromium.org/587703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
