On 2014/09/23 10:36:11, Jens Widell wrote:
I'll investigate rethrow-error-from-bindings-crash.html, but since that's
a
test
specifically about rethrowing errors, it seems likely they trigger code
that
does that, and thus would be (correctly) affected by this fix.
Here's what I think is going on with this test:
When Isolate::DoThrow() calls Debug::OnThrow(), the pending message stored
in
the isolate is lost. Without this patch, the message is regenerated again
(by
accident; not because it was lost) so the fact that it was lost made no
particular difference. With this patch, we do not generate a new message, so
then the fact that it was lost, means no message is logged to the console.
Advise on what to do about this?
Semi-unrelated:
The test tests two methods, Node.appendChild() and
Range.compareBoundaryPoints(). The generated bindings code for the latter
has a
v8::TryCatch local (always rethrown) while the former does not. Only the
latter
has a problem. And we are getting rid of these v8::TryCatch objects. I can
work
around this test failure by landing a CL that removes the v8::TryCatch.
https://codereview.chromium.org/587703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
