I applied the patch locally and getting the following error when building
x64.debug:
$ make x64.debug.check -j300
make[1]: Entering directory `/sources/chromium/src/v8/out'
LINK(target) /sources/chromium/src/v8/out/x64.debug/mksnapshot
/sources/chromium/src/v8/out/x64.debug/obj.target/v8_base/src/cpu-profiler.o:
In
function `v8::internal::JITLineInfoTable::GetSourceLineNumber(int) const':
/sources/chromium/src/v8/out/.././src/profile-generator.h:67: undefined
reference to `v8::CpuProfileNode::kNoLineNumberInfo'
collect2: ld returned 1 exit status
make[1]: *** [/sources/chromium/src/v8/out/x64.debug/mksnapshot] Error 1
make[1]: Leaving directory `/sources/chromium/src/v8/out'
make: *** [x64.debug] Error 2
Could you please fix that?
Also it might make sense to move implementation of JITLineInfoTable methods
into
profile-generator.cc for better readability. But it is up to you.
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
