On 2014/10/02 08:26:38, Denis Pravdin wrote:
On 2014/10/02 07:54:52, yurys wrote:
> I applied the patch locally and getting the following error when
building
> x64.debug:
>
> $ make x64.debug.check -j300
> make[1]: Entering directory `/sources/chromium/src/v8/out'
> LINK(target) /sources/chromium/src/v8/out/x64.debug/mksnapshot
>
/sources/chromium/src/v8/out/x64.debug/obj.target/v8_base/src/cpu-profiler.o:
In
> function `v8::internal::JITLineInfoTable::GetSourceLineNumber(int)
const':
> /sources/chromium/src/v8/out/.././src/profile-generator.h:67: undefined
> reference to `v8::CpuProfileNode::kNoLineNumberInfo'
> collect2: ld returned 1 exit status
> make[1]: *** [/sources/chromium/src/v8/out/x64.debug/mksnapshot] Error 1
> make[1]: Leaving directory `/sources/chromium/src/v8/out'
> make: *** [x64.debug] Error 2
>
> Could you please fix that?
>
> Also it might make sense to move implementation of JITLineInfoTable
methods
into
> profile-generator.cc for better readability. But it is up to you.
Yeah, I saw this linker error on Linux debug configuration only after I
applied
my patch. But it seems that the problem is there even before my patch.
The include/v8-profiler.h file includes a constant initializer for
kNoLineNumberInfo. I know that class static const integral member is not
required to be defined out of class. But it's better to define
CpuProfileNode::kNoLineNumberInfo somewhere.
I fixed it locally, just for testing.
src/cpu_profiler.cc:
namespace v8 {
const int CpuProfileNode::kNoLineNumberInfo;
}
I can't permissions to upload the patch (that's a reason I am asking
Weiliang
to
help me with the patch) for review. Weiliang is OOO to Oct 7 due to PRC
national
Holiday.
Can you fix the linker error and then apply my patch or you prefer to
wait for
one more patch?
Done. Uploaded your patch and a fix on top of it as
https://codereview.chromium.org/616963005/
Thanks,
Denis
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
