Looking good, some comments
https://codereview.chromium.org/631433002/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/631433002/diff/20001/src/preparser.h#newcode153
src/preparser.h:153: *scope_stack_ = scope_;
Why do you need this constructor?
https://codereview.chromium.org/631433002/diff/20001/src/preparser.h#newcode2765
src/preparser.h:2765: BlockState block_state(&scope_, &scope);
Seems like BlockState block_state(&scope_, scope) will do just fine
here.
https://codereview.chromium.org/631433002/diff/20001/src/runtime/runtime.cc
File src/runtime/runtime.cc (right):
https://codereview.chromium.org/631433002/diff/20001/src/runtime/runtime.cc#newcode376
src/runtime/runtime.cc:376: prototype_parent =
isolate->initial_object_prototype();
What happens, per spec, if user assigns to Object.prototype?
https://codereview.chromium.org/631433002/diff/20001/src/runtime/runtime.cc#newcode405
src/runtime/runtime.cc:405: isolate, JSObject::SetPrototype(prototype,
prototype_parent, false));
Instead of SetPrototype here, I suggest using NewJSObjectFromMap with an
appropriate Map (the prototype field of which is set to
prototype_parent), so that we can avoid prototype mutation.
https://codereview.chromium.org/631433002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
