On 2014/10/07 16:13:19, arv wrote:
https://codereview.chromium.org/631433002/diff/40001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/631433002/diff/40001/src/globals.h#newcode769
src/globals.h:769: kConstructorMethod = kNormalFunction
On 2014/10/07 15:21:05, Dmitry Lomov (chromium) wrote:
> On 2014/10/07 15:16:52, arv wrote:
> > On 2014/10/07 15:09:37, Dmitry Lomov (chromium) wrote:
> > > Set but unused? Let's remove it.
> >
> > It is used in preparser.h. I can change that to use kNormalFunction
but I
> found
> > that this makes it more clear what is going on.
>
> Right, I've seen that. Let's not add constants that have no operational
meaning
> - it is just confusing - one has to look up whether constructor method
is
> somehow different from normal method.
Done.
lgtm
https://codereview.chromium.org/631433002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
