lgtm with nits.
https://codereview.chromium.org/631433002/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/631433002/diff/20001/src/preparser.h#newcode153
src/preparser.h:153: *scope_stack_ = scope_;
On 2014/10/07 14:47:09, arv wrote:
On 2014/10/07 10:28:32, Dmitry Lomov (chromium) wrote:
> Why do you need this constructor?
This is due to how parser and preparser typedef Scope differently.
We have the same duplication of the constructor for FunctionState.
Could we investigate the possibility of removing this discrepancy
between prepaser and parser? This is very confusing (not necessarily in
this CL)
https://codereview.chromium.org/631433002/diff/40001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/631433002/diff/40001/src/globals.h#newcode769
src/globals.h:769: kConstructorMethod = kNormalFunction
Set but unused? Let's remove it.
https://codereview.chromium.org/631433002/diff/40001/src/runtime/runtime.cc
File src/runtime/runtime.cc (right):
https://codereview.chromium.org/631433002/diff/40001/src/runtime/runtime.cc#newcode433
src/runtime/runtime.cc:433: if (has_constructor_parent) {
Replace with constructor_parent.is_null() and remove flag?
https://codereview.chromium.org/631433002/diff/40001/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/631433002/diff/40001/test/mjsunit/mjsunit.status#newcode74
test/mjsunit/mjsunit.status:74: 'harmony/classes': [PASS, NO_VARIANTS],
You should not need this after
https://code.google.com/p/v8/source/detail?r=24435.
Don't forget to remove after you rebase.
https://codereview.chromium.org/631433002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
