https://codereview.chromium.org/636403003/diff/1/src/ast-numbering.cc
File src/ast-numbering.cc (right):
https://codereview.chromium.org/636403003/diff/1/src/ast-numbering.cc#newcode24
src/ast-numbering.cc:24: #define DEFINE_VISIT(type) \
On 2014/10/14 11:06:00, Sven Panne wrote:
I don't like this 2nd order macro horror, although I understand the
motivation
behind it: Separating the recursion scheme from the actual logic per
node.
As it is, it obfuscates things more than it helps, so just directly
implement
all those VisitFoo directly (where Foo is an AST node type). This
takes 10
minutes more to write and saves 10h reading the code later.
Acutally, I think it's silly that all visitors need to implement the
recursive AST walking themselves. Can't we have it implemented in one
place (in the superclass) and if the actual visitors want to do
something else than just visit children, they'd need to override the
corresponding func?
https://codereview.chromium.org/636403003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
