Turns out in the previous version I was doing an n² traversal -- it was
recursing into nested functions, always. I fixed this, and also fixed some
cases where it wasn't reaching all the AST nodes that needed reaching, also
in
cases involving invalid redeclarations. Finally I moved the Renumber() for
the
full-codegen case into FullCodegen::MakeCode, as there are a few ways to get
there.
The end result here is that now the time for my --no-lazy benchmark is
0.124s,
rather than 0.128 before (and compared to 0.122 before the patch). I'm
running
the fuzzer now but I think everything's going to go well, and these new
numbers
are close enough that I think we can probably land directly. WDYT?
https://codereview.chromium.org/636403003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
