Fixed nits.
https://codereview.chromium.org/636403003/diff/270001/src/ast-numbering.h
File src/ast-numbering.h (right):
https://codereview.chromium.org/636403003/diff/270001/src/ast-numbering.h#newcode13
src/ast-numbering.h:13: class AstNumbering {
On 2014/10/15 07:41:56, Sven Panne wrote:
This is not really a class, using a namespace might be more honest.
Done.
https://codereview.chromium.org/636403003/diff/270001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/636403003/diff/270001/src/ast.h#newcode379
src/ast.h:379: base_id_(INT_MIN) {}
Done. I kept the initialization as the check helps during development
-- otherwise it's easy for an AST change to bork because you didn't
change the corresponding place in ast-numbering.cc.
https://codereview.chromium.org/636403003/diff/270001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/636403003/diff/270001/src/parser.cc#newcode882
src/parser.cc:882: zone(), ast_value_factory());
On 2014/10/15 07:41:56, Sven Panne wrote:
A nice little cleanup which could be done on the way: Remove the Zone*
argument
from the AstNodeFactory, the zone can (and should!) be retrieved fromt
the
AstValueFactory (add a getter there). It simply doesn't make sense to
pretend
that AST nodes and AST values can live in different zones.
Done.
https://codereview.chromium.org/636403003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
