LGTM, with monor nits
https://codereview.chromium.org/422923004/diff/60001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/422923004/diff/60001/test/cctest/test-parsing.cc#newcode927
test/cctest/test-parsing.cc:927: { "f = () => { \"use strict\";", "}" },
It can't harm to keep these variants, you never know...
https://codereview.chromium.org/422923004/diff/80001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/422923004/diff/80001/src/objects.h#newcode4305
src/objects.h:4305: class AsmModuleField : public BitField<bool, 11, 1>
{};
Nit: while you're here, reformat these to match the others.
https://codereview.chromium.org/422923004/diff/80001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/422923004/diff/80001/src/scopes.cc#newcode786
src/scopes.cc:786: case ARROW_SCOPE:
Nit: no newline
https://codereview.chromium.org/422923004/diff/80001/src/scopes.cc#newcode1184
src/scopes.cc:1184: if (inner->is_arrow_scope() ||
!inner->is_function_scope()) {
Nit: switch around the two conditions (the more general one should go
first).
https://codereview.chromium.org/422923004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
