On 2014/10/13 17:59:38, aperez wrote:
On 2014/09/10 06:33:56, rossberg wrote:
> Unfortunately, we can't use C++11 yet...
Fixed. My brain subconsciously keeps insisting in C+11 being the
way to go... ;-)
In fact, you can use it now. :)
https://codereview.chromium.org/422923004/diff/60001/test/cctest/test-parsing.cc#newcode950
> test/cctest/test-parsing.cc:950: { "var x = function () { this.foo = 42
};",
> On 2014/09/04 16:41:21, arv wrote:
> > Why do we need to track the this reference inside a function
expression?
>
> Indeed, this seems wrong. Although it should be true for an arrow
function.
I am not sure how to proceed WRT this. Now that propagation of
the "inner_uses_$foo" flags does not go outside normal function
scopes, it is clearly something that pertains only to arrow
functions... so how about renaming to "arrow_inner_uses_$foo"?
That would better indicate that the flag is relevant only for
arrow functions.
Keeping the current name is fine with me.
https://codereview.chromium.org/422923004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
