The nits should be fixed now.
https://codereview.chromium.org/422923004/diff/60001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/422923004/diff/60001/test/cctest/test-parsing.cc#newcode927
test/cctest/test-parsing.cc:927: { "f = () => { \"use strict\";", "}" },
On 2014/10/15 12:56:32, rossberg wrote:
It can't harm to keep these variants, you never know...
The issue with keeping those is that making the function
strict enables block scoping, so the expected test results
vary for some the cases below, for example in thi one:
{ "if (foo()) { this.f() }",
true, false, false, false },
It would generate those two inputs:
function () { if (foo()) { this.f() } }
function () { "use strict"; if (foo()) { this.f() } }
For the first one "uses_this" is expected to be "true"
(and "inner_uses_this" expected to be "false"), but for
the second one it has to be "false" because the usage
of "this" is in the block scope of the "if"...
This is why I have removed the prefixes which introduce
add the ""use strict";" and added some extra cases at the
end of "source_data" that enable strict mode.
https://codereview.chromium.org/422923004/diff/80001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/422923004/diff/80001/src/objects.h#newcode4305
src/objects.h:4305: class AsmModuleField : public BitField<bool, 11, 1>
{};
On 2014/10/15 12:56:32, rossberg wrote:
Nit: while you're here, reformat these to match the others.
Acknowledged.
https://codereview.chromium.org/422923004/diff/80001/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/422923004/diff/80001/src/scopes.cc#newcode786
src/scopes.cc:786: case ARROW_SCOPE:
On 2014/10/15 12:56:32, rossberg wrote:
Nit: no newline
Acknowledged.
https://codereview.chromium.org/422923004/diff/80001/src/scopes.cc#newcode1184
src/scopes.cc:1184: if (inner->is_arrow_scope() ||
!inner->is_function_scope()) {
On 2014/10/15 12:56:32, rossberg wrote:
Nit: switch around the two conditions (the more general one should go
first).
Acknowledged.
https://codereview.chromium.org/422923004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
