Are you sure this runs the fast case?
http://codereview.chromium.org/217014/diff/1/2 File src/arm/builtins-arm.cc (right): http://codereview.chromium.org/217014/diff/1/2#newcode69 Line 69: static const int kPreallocatedArrayElements = 4; This should probably be moved out of the architecture independent files. http://codereview.chromium.org/217014/diff/1/2#newcode73 Line 73: // register. If the parameter holes is larger than zero an elements backing holes -> 'holes' zero -> zero, http://codereview.chromium.org/217014/diff/1/2#newcode82 Line 82: int holes, I would prefer a more descriptive name like preallocated_elements http://codereview.chromium.org/217014/diff/1/2#newcode92 Line 92: if (holes > 0) { I think we should just assert that holes is > 0 and remove this unrunnable code. http://codereview.chromium.org/217014/diff/1/2#newcode116 Line 116: if (holes == 0) { And here. http://codereview.chromium.org/217014/diff/1/2#newcode149 Line 149: if (holes <= kLoopUnfoldLimit) { And here assert that holes is less than kLoopUnfoldLimit. http://codereview.chromium.org/217014/diff/1/2#newcode213 Line 213: __ AllocateObjectInNewSpace(scratch, It doesn't look to me like AllocateObjectInNewSpace works if the first and 4th parameters are the same register. http://codereview.chromium.org/217014 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
