Fixed the bug you discovered, please take another look.
http://codereview.chromium.org/217014/diff/1/2 File src/arm/builtins-arm.cc (right): http://codereview.chromium.org/217014/diff/1/2#newcode69 Line 69: static const int kPreallocatedArrayElements = 4; On 2009/09/22 12:48:54, Erik Corry wrote: > This should probably be moved out of the architecture independent files. Done. http://codereview.chromium.org/217014/diff/1/2#newcode73 Line 73: // register. If the parameter holes is larger than zero an elements backing On 2009/09/22 12:48:54, Erik Corry wrote: > holes -> 'holes' > zero -> zero, Done. http://codereview.chromium.org/217014/diff/1/2#newcode82 Line 82: int holes, On 2009/09/22 12:48:54, Erik Corry wrote: > I would prefer a more descriptive name like preallocated_elements Changed to initial_capacity. http://codereview.chromium.org/217014/diff/1/2#newcode92 Line 92: if (holes > 0) { On 2009/09/22 12:48:54, Erik Corry wrote: > I think we should just assert that holes is > 0 and remove this unrunnable code. Done. http://codereview.chromium.org/217014/diff/1/2#newcode116 Line 116: if (holes == 0) { On 2009/09/22 12:48:54, Erik Corry wrote: > And here. Done. http://codereview.chromium.org/217014/diff/1/2#newcode149 Line 149: if (holes <= kLoopUnfoldLimit) { On 2009/09/22 12:48:54, Erik Corry wrote: > And here assert that holes is less than kLoopUnfoldLimit. Removed kLoopUnfoldLimit (constant only used in an ASSERT requires #ifdef DEBUG/#endif) and put in the constant 10. http://codereview.chromium.org/217014/diff/1/2#newcode213 Line 213: __ AllocateObjectInNewSpace(scratch, On 2009/09/22 12:48:54, Erik Corry wrote: > It doesn't look to me like AllocateObjectInNewSpace works if the first and 4th > parameters are the same register. Good catch - the code from here and forward did not work at all. It was pure luck that the tests passed. Just starting the ARMû shell crashed. http://codereview.chromium.org/217014 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
