LGTM. Consider combining the size-from-register and size-in-constant cases to reduce code size.
http://codereview.chromium.org/217014/diff/1/2 File src/arm/builtins-arm.cc (right): http://codereview.chromium.org/217014/diff/1/2#newcode149 Line 149: if (holes <= kLoopUnfoldLimit) { On 2009/09/23 07:03:52, Søren Gjesse wrote: > On 2009/09/22 12:48:54, Erik Corry wrote: > > And here assert that holes is less than kLoopUnfoldLimit. > Removed kLoopUnfoldLimit (constant only used in an ASSERT requires #ifdef > DEBUG/#endif) and put in the constant 10. That must be fixable. http://codereview.chromium.org/217014/diff/4001/4002#newcode314 Line 314: // Handle construction of an empty array. to large -> too large http://codereview.chromium.org/217014/diff/4001/4002#newcode361 Line 361: __ add(sp, sp, Operand(2 * kPointerSize)); Note sentence starting "Note" therefore the use of grammar. http://codereview.chromium.org/217014/diff/4001/4002#newcode407 Line 407: __ bind(&entry); as -> as a http://codereview.chromium.org/217014/diff/4001/4002#newcode410 Line 410: in case -> if http://codereview.chromium.org/217014/diff/4001/4002#newcode430 Line 430: does always have -> always has http://codereview.chromium.org/217014/diff/4001/4002#newcode442 Line 442: as -> as a http://codereview.chromium.org/217014 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
