Looking pretty good, just a couple of nits, and if you can test fill with
large
array, negative start offset, and/or negative end offset, I think we're
good to
go.
https://codereview.chromium.org/553623004/diff/190001/test/mjsunit/array-length.js
File test/mjsunit/array-length.js (right):
https://codereview.chromium.org/553623004/diff/190001/test/mjsunit/array-length.js#newcode148
test/mjsunit/array-length.js:148: assertEquals(o.length,
Number.MAX_SAFE_INTEGER + 1);
Perhaps check that pushing another value keeps the same length and
overwrites the old value.
https://codereview.chromium.org/553623004/diff/190001/test/mjsunit/array-length.js#newcode216
test/mjsunit/array-length.js:216: assertEquals(0, o.length);
These are two of the same test
https://codereview.chromium.org/553623004/diff/190001/test/mjsunit/array-length.js#newcode254
test/mjsunit/array-length.js:254: // ArrayLasIndexOf
Last
https://codereview.chromium.org/553623004/diff/190001/test/mjsunit/array-length.js#newcode264
test/mjsunit/array-length.js:264: assertEquals(arrayMaxLength, result);
I guess I am mostly concerned here about
var o = { length: Number.MAX_SAFE_INTEGER }
o[Number.MAX_SAFE_INTEGER - 1] = "foo"
Can you try that for indexOf and lastIndexOf?
https://codereview.chromium.org/553623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
