On 2014/10/22 09:49:31, wingo wrote:
Looking pretty good, just a couple of nits, and if you can test fill with
large
array, negative start offset, and/or negative end offset, I think we're
good
to
go.
Added test.
Can you try that for indexOf and lastIndexOf?
Fixed last issues. Needs another round of review.
On the other hand, I searched for expressions that cast array.length as an
UINT32 in "array.js" and there are still some functions that do that. More
precisely: ObservedArrayPush, ObservedArrayUnshift, ObservedArraySplice,
SafeRemoveArrayHoles. It seems reasonable to replace those too, but I
couldn't
find these functions in the ES6 spec.
https://codereview.chromium.org/553623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
