This looks good, my only concern is that it's a breaking change, and yet,
not
behind a flag. I wonder if there is an easy (and efficient) way to flag it.
If
not, we should probably wait with landing this until after the M40 branch
end of
next week.
https://codereview.chromium.org/553623004/diff/230001/test/mjsunit/array-length.js
File test/mjsunit/array-length.js (right):
https://codereview.chromium.org/553623004/diff/230001/test/mjsunit/array-length.js#newcode245
test/mjsunit/array-length.js:245: var result =
Array.prototype.indexOf.apply(o, ["foo", Number.MAX_SAFE_INTEGER - 2]);
nit: line length
https://codereview.chromium.org/553623004/diff/230001/test/mjsunit/array-length.js#newcode261
test/mjsunit/array-length.js:261: var result =
Array.prototype.lastIndexOf.apply(o, ["foo", Number.MAX_SAFE_INTEGER]);
nit: line length
https://codereview.chromium.org/553623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
