On 2014/10/24 08:25:12, Sven Panne wrote:
lgtm
https://codereview.chromium.org/675493002/diff/40001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/675493002/diff/40001/src/compiler.cc#newcode931
src/compiler.cc:931: if (!Renumber(&unoptimized)) return false;
Why do we need that here, i.e. what is the path leading to that point
where we
have an "un-numbered" AST?
Ooops, klicked LGTM instead of just "Publish". Things look OK, but before we
land this, I'd like to understand the point above. Another related
question: Is
there a path where we Renumber() twice? It's a bit hard to see (but that's
not
your fault).
https://codereview.chromium.org/675493002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
