Thanks for the review -- fixed nits and landing
https://codereview.chromium.org/675493002/diff/60001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/675493002/diff/60001/src/compiler.cc#newcode922
src/compiler.cc:922: bool
Compiler::EnsureDeoptimizationSupport(CompilationInfo* info) {
On 2014/10/27 11:41:54, Michael Starzinger wrote:
nit: We might even want to add a two assertions here ...
DCHECK(info->function() != NULL);
DCHECK(info->scope() != NULL);
Done.
https://codereview.chromium.org/675493002/diff/60001/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/675493002/diff/60001/src/compiler.h#newcode686
src/compiler.h:686: static bool
EnsureDeoptimizationSupport(CompilationInfo* info);
On 2014/10/27 11:41:54, Michael Starzinger wrote:
nit: I know it's not part of you change, but can we also add a comment
here
(above EnsureDeoptimizationSupport) saying that ParseAndAnalyze needs
to have
been called before? Something along the lines of ...
// Adds deoptimization support, requires ParseAndAnalyze.
Also it might make sense to move it up to right after Analyze(), to
make clear
that it is (optionally) part of the pipeline.
Done.
https://codereview.chromium.org/675493002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
