On 2014/10/24 08:26:49, Sven Panne wrote:
Is
there a path where we Renumber() twice? It's a bit hard to see (but
that's not
your fault).
I don't really know. There are two possible cases:
1. Any time you call Analyze() instead of ParseAndAnalyze()
2. Any time you call Renumber()
(1) only happens in CompileUnoptimized code AFAICS; anyway this is the same
state of things as before, as it also calls Rewrite() and
Scope::Analyze(). I
can't convince myself that duplicate calls are impossible, but since
Rewrite /
Scope::Analyze can change the AST we have to renumber there
(2) happens in BuildFunctionInfo, which usually happens when visiting a
function
via AST traversal. If the FunctionLiteral survives traversal (to then be
traversed again) then I guess it's possible, but unlikely; it would only
happen
for parenthesized functions.
So in summary I don't really know :)
https://codereview.chromium.org/675493002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
