https://codereview.chromium.org/682643002/diff/140001/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):
https://codereview.chromium.org/682643002/diff/140001/src/arm/disasm-arm.cc#newcode1290
src/arm/disasm-arm.cc:1290: // vrintr - round according to rounding mode
in FPSCR
vrintr is not implemented by this patch, usually the disassembler only
provide support for what V8 generates (and test). So how about calling
Unknown(instr); here.
https://codereview.chromium.org/682643002/diff/140001/src/arm/disasm-arm.cc#newcode1659
src/arm/disasm-arm.cc:1659: Format(instr, "vrinta.f32.f32 'Sd, 'Sm");
You don't implement single precision, so I would handle them as unknown
instructions.
Same apply for vrintn/p/m below.
https://codereview.chromium.org/682643002/diff/140001/test/cctest/test-assembler-arm.cc
File test/cctest/test-assembler-arm.cc (right):
https://codereview.chromium.org/682643002/diff/140001/test/cctest/test-assembler-arm.cc#newcode1707
test/cctest/test-assembler-arm.cc:1707: __ sub(fp, ip, Operand(4));
This is not necessary, you should be able to only store r4 and lr. This
has no impact on the test so up to you.
https://codereview.chromium.org/682643002/diff/140001/test/cctest/test-assembler-arm.cc#newcode1711
test/cctest/test-assembler-arm.cc:1711: // Test vrint
nit: vrinta
https://codereview.chromium.org/682643002/diff/140001/test/cctest/test-disasm-arm.cc
File test/cctest/test-disasm-arm.cc (right):
https://codereview.chromium.org/682643002/diff/140001/test/cctest/test-disasm-arm.cc#newcode501
test/cctest/test-disasm-arm.cc:501: COMPARE(vsqrt(d0, d0), "eeb10bc0
vsqrt.f64 d0, d0");
nit: copy/paste error.
https://codereview.chromium.org/682643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
