LGTM with comments.
https://codereview.chromium.org/682643002/diff/180001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/682643002/diff/180001/src/arm/assembler-arm.cc#newcode3101
src/arm/assembler-arm.cc:3101: int vd, d;
DCHECK(CpuFeature::IsSupported(ARMv8)); I miss that the first time
sorry.
Same for all vrint below
https://codereview.chromium.org/682643002/diff/180001/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):
https://codereview.chromium.org/682643002/diff/180001/src/arm/disasm-arm.cc#newcode1282
src/arm/disasm-arm.cc:1282: if (instr->Opc3Value() & 0x2) {
You could move this check in the if above to simplify the code:
if (... && (instr->Opc3Value() == 0x3)) {
https://codereview.chromium.org/682643002/diff/180001/src/arm/disasm-arm.cc#newcode1287
src/arm/disasm-arm.cc:1287: Format(instr, "vrintz'cond.f32.f32 'Sd,
'Sm");
Not used by V8
https://codereview.chromium.org/682643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
