https://codereview.chromium.org/682643002/diff/200001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):
https://codereview.chromium.org/682643002/diff/200001/src/arm/simulator-arm.cc#newcode3627
src/arm/simulator-arm.cc:3627: dd_value = std::round(dm_value);
The calls to std::round and std::trunc added here require a C++11
standard library, as those were not available in the std:: namespace
previously. This broke building the android webview on mac where the
default C++ library is still the crappy old one from gcc 4.2 :/
I'm investigating fixing the android build system downstream to use
libc++ to avoid issues like this in the future, but is this dependency
against the current chromium policy of not depending on C++11 library
features? Does V8 follow that policy?
I'm not insisting this be changed, just pointing it out in case it was
accidental. If it's fine, then we'll get it dealt with downstream.
https://codereview.chromium.org/682643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
