Looking good to me.
https://codereview.chromium.org/391693002/diff/80001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/391693002/diff/80001/src/flag-definitions.h#newcode934
src/flag-definitions.h:934: "enable in-object double fields unboxing
(X64 only)")
64-bit only
https://codereview.chromium.org/391693002/diff/80001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/391693002/diff/80001/src/globals.h#newcode90
src/globals.h:90: #define V8_DOUBLE_FIELDS_UNBOXING 0
?
https://codereview.chromium.org/391693002/diff/80001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/391693002/diff/80001/src/objects-inl.h#newcode3202
src/objects-inl.h:3202:
Add a comment why this is a good idea (not wasting space, beneficial
when appending new descriptors).
https://codereview.chromium.org/391693002/diff/80001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/391693002/diff/80001/src/objects.h#newcode4832
src/objects.h:4832: class LayoutDescriptor : public
FixedTypedArray<Uint32ArrayTraits> {
What about putting this in a separate file?
https://codereview.chromium.org/391693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
