https://codereview.chromium.org/391693002/diff/160001/src/heap/objects-visiting.h
File src/heap/objects-visiting.h (right):
https://codereview.chromium.org/391693002/diff/160001/src/heap/objects-visiting.h#newcode238
src/heap/objects-visiting.h:238: IterateRawPointers(heap, object,
offset, offset + kPointerSize);
On 2014/11/10 15:26:08, Hannes Payer wrote:
On 2014/11/07 08:03:52, Igor Sheludko wrote:
> On 2014/11/06 12:29:46, Hannes Payer wrote:
> > Instead of calling this for each field, do you think it has a
performance
> > advantage to call it over maximum contiguous pointer ranges?
> > It is probably more readable how it is implemented right now.
>
> Good point! But let me do that in a next CL.
Then please leave a todo.
Done.
https://codereview.chromium.org/391693002/diff/160001/src/heap/store-buffer.cc
File src/heap/store-buffer.cc (right):
https://codereview.chromium.org/391693002/diff/160001/src/heap/store-buffer.cc#newcode523
src/heap/store-buffer.cc:523: FindPointersToNewSpaceInRegion(slot, slot
+ kPointerSize,
On 2014/11/10 15:26:08, Hannes Payer wrote:
On 2014/11/07 08:03:52, Igor Sheludko wrote:
> On 2014/11/06 12:29:46, Hannes Payer wrote:
> > Similar as before, do you think maximum contiguous pointer ranges
make sense
> > here?
>
> I would prefer to implement that in a next CL.
Then please leave a todo.
Done.
https://codereview.chromium.org/391693002/diff/160001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/391693002/diff/160001/src/objects-inl.h#newcode2082
src/objects-inl.h:2082: return
!map()->layout_descriptor()->IsTagged(index.property_index());
On 2014/11/10 15:26:08, Hannes Payer wrote:
On 2014/11/07 08:03:52, Igor Sheludko wrote:
> On 2014/11/06 12:29:46, Hannes Payer wrote:
> > You could call IsUnboxedDoubleFrield from map.
>
> I made two versions intentionally, to postpone call to map() to as
late as
> possible.
You are already calling map here. You could call
map()->IsUnboxedDoubleField(index) instead of
!map()->layout_descriptor()->IsTagged(index.property_index());
Ok, lets make it look cleaner. Done.
https://codereview.chromium.org/391693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
