https://codereview.chromium.org/391693002/diff/120001/src/heap/objects-visiting.h
File src/heap/objects-visiting.h (right):
https://codereview.chromium.org/391693002/diff/120001/src/heap/objects-visiting.h#newcode109
src/heap/objects-visiting.h:109: bool has_unboxed_fields);
Use enum rather than bool
https://codereview.chromium.org/391693002/diff/120001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/391693002/diff/120001/src/objects.cc#newcode8120
src/objects.cc:8120: if (layout_descriptor_length <= field_index +
field_width_in_words - 1) {
layout_descriptor_length = Max(layout_descriptor_length, field_index +
field_width_in_words)
https://codereview.chromium.org/391693002/diff/120001/src/objects.cc#newcode8144
src/objects.cc:8144: layout_descriptor =
layout_descriptor->SetTagged(field_index, false);
What about having a "SetDouble" or "SetRawData" rather than
SetTagged(..false)
https://codereview.chromium.org/391693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
