I agree it would be nice to get the raw text in a better way, but there are
so
many different rules for TRV that I wasn't sure if it would be safe to do it
that way. At least for line endings they need to be normalized, and I'm not
sure
the scanner does this on its own.
https://codereview.chromium.org/663683006/diff/180001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/663683006/diff/180001/test/cctest/test-parsing.cc#newcode4321
test/cctest/test-parsing.cc:4321: "`no-subst-template`",
On 2014/11/07 16:55:50, arv wrote:
Also include an empty one
``
Done.
https://codereview.chromium.org/663683006/diff/180001/test/cctest/test-parsing.cc#newcode4323
test/cctest/test-parsing.cc:4323: "`${a}template-tail`",
On 2014/11/07 16:55:50, arv wrote:
How about one with only a place holder
`${a}`
Done.
https://codereview.chromium.org/663683006/diff/180001/test/mjsunit/es6/templates.js
File test/mjsunit/es6/templates.js (right):
https://codereview.chromium.org/663683006/diff/180001/test/mjsunit/es6/templates.js#newcode28
test/mjsunit/es6/templates.js:28: // Multi-line templates
On 2014/11/07 16:55:50, arv wrote:
How about testing one with \r\n too?
the trouble with that (from an mjsunit test) is that it's likely the
line endings in the test file would be normalized to plain LFs at some
point.
It would make a good API test because then there's some control over the
line endings.
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
