Thx; it's much clearer now.
I didn't yet have a close look at CloseTemplateLiteral, will do that
tomorrow.
It would be theoretically possible to just store a representation of the raw
literal, since we can always get the cooked literal from it (we'd need to
store
\uxxx instead of uxxx like we do now), and then we could have a conversion
function... but idk if that would make the code any cleaner or just messier.
https://codereview.chromium.org/663683006/diff/240001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/663683006/diff/240001/src/preparser.h#newcode2918
src/preparser.h:2918: return Traits::CloseTemplateLiteral(&ts, start,
tag);
Nit: there's only one break above, so you can move this line there, and
DCHECK(false); here (the only way to get away from the infinite loop is
to return, right, we don't want to do any actions after it if I
understood it right).
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
