On 2014/11/11 08:51:03, marja wrote:
caitp, wdyt about arv's idea: not storing the raw string but getting it
from
the
source code if needed? That would simplify the parsing / scanning part.
Would
that be feasible?
It should be feasible, but I've not yet seen how I can do that, and I
expect it
would still be messy due to the line ending normalization that needs to
happen.
I'll look at doing that today though
https://codereview.chromium.org/663683006/diff/260001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/663683006/diff/260001/src/preparser.h#newcode2877
src/preparser.h:2877: // Add TV / TRV
On 2014/11/11 09:47:24, marja wrote:
This comment is confusing... which part is adding the TV / TRV?
I think that's a stray comment, doesn't look like it belongs here
https://codereview.chromium.org/663683006/diff/260001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/663683006/diff/260001/src/scanner.cc#newcode819
src/scanner.cc:819: PushBack('}');
On 2014/11/11 09:47:24, marja wrote:
Hmm, when does this happen and why do we PushBack?
After parsing an expression, the scanner ends up with a peeked RBRACE
and we're at the wrong position in source, I'm not sure if this is the
right way to deal with that but it seems to work.
Without this, it if you have a template like `${a}`, it misses the
ending backtick and breaks, which is bad
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
