looking good, just a couple comments
https://codereview.chromium.org/722793005/diff/60001/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/722793005/diff/60001/src/full-codegen.cc#newcode1581
src/full-codegen.cc:1581: this, lit->scope(), BailoutId::None(),
BailoutId::None(),
Nice!
https://codereview.chromium.org/722793005/diff/60001/src/full-codegen.cc#newcode1785
src/full-codegen.cc:1785: codegen_->PrepareForBailoutForId(entry_id,
NO_REGISTERS);
This should crash under --always-opt when entry_id == BailoutId::kNone.
You will have to protect it here specifically.
While you are here, maybe add a DCHECK in PrepareForBailoutForId that
the id it not None.
https://codereview.chromium.org/722793005/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/722793005/diff/60001/src/parser.cc#newcode3960
src/parser.cc:3960: ObjectLiteral::Property* property =
ParsePropertyDefinition(
Nit: move has_seen_constructor variable here (it is not used outside the
look AFAICS)
https://codereview.chromium.org/722793005/diff/60001/src/parser.cc#newcode3980
src/parser.cc:3980: this->DefaultConstructor(extends != NULL,
block_scope, pos, end_pos);
Nit: remove 'this->'
https://codereview.chromium.org/722793005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
