lgtm if tests pass. I am still curious about BailoutIds though.
On 2014/11/13 21:56:29, arv wrote:
https://codereview.chromium.org/722793005/diff/60001/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/722793005/diff/60001/src/full-codegen.cc#newcode1785
src/full-codegen.cc:1785: codegen_->PrepareForBailoutForId(entry_id,
NO_REGISTERS);
On 2014/11/13 21:10:37, Dmitry Lomov (chromium) wrote:
> This should crash under --always-opt when entry_id == BailoutId::kNone.
You
will
> have to protect it here specifically.
>
> While you are here, maybe add a DCHECK in PrepareForBailoutForId that
the id
it
> not None.
Since ClassLiteral is not optimized this is fine.
Hmm, I though even though ClassLiteral is not optimized we can still compile
with deopt data support and this will break.
Maybe that has changed?
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/full-codegen.cc&l=473
https://codereview.chromium.org/722793005/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/722793005/diff/60001/src/parser.cc#newcode3960
src/parser.cc:3960: ObjectLiteral::Property* property =
ParsePropertyDefinition(
On 2014/11/13 21:10:37, Dmitry Lomov (chromium) wrote:
> Nit: move has_seen_constructor variable here (it is not used outside the
look
> AFAICS)
It needs to be done outside the loop since ParsePropertyDefinition
returns a
parse error if it finds a second constructor.
Ah, got it. Sorry for the noise.
https://codereview.chromium.org/722793005/diff/60001/src/parser.cc#newcode3980
src/parser.cc:3980: this->DefaultConstructor(extends != NULL, block_scope,
pos,
end_pos);
On 2014/11/13 21:10:37, Dmitry Lomov (chromium) wrote:
> Nit: remove 'this->'
Done.
https://codereview.chromium.org/722793005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
