I'm not sure having this infrastructure is worth it, as opposed to just
skipping
the test forever. But if you'd like to have it, I'm not opposed. I have some
comments, though.
https://codereview.chromium.org/735723006/diff/1/test/mozilla/mozilla.status
File test/mozilla/mozilla.status (right):
https://codereview.chromium.org/735723006/diff/1/test/mozilla/mozilla.status#newcode897
test/mozilla/mozilla.status:897: ['arch == arm64 and simulator_run ==
True', {
We already have such a section below, please move the new expectation
there.
https://codereview.chromium.org/735723006/diff/1/tools/testrunner/local/testsuite.py
File tools/testrunner/local/testsuite.py (right):
https://codereview.chromium.org/735723006/diff/1/tools/testrunner/local/testsuite.py#newcode139
tools/testrunner/local/testsuite.py:139: for outc in t.outcomes:
nit: no reason to abbreviate, s/outc/outcome/.
https://codereview.chromium.org/735723006/diff/1/tools/testrunner/local/testsuite.py#newcode140
tools/testrunner/local/testsuite.py:140: assert type(outc) == str
Let's drop the assert (this code is fairly performance sensitive).
https://codereview.chromium.org/735723006/diff/1/tools/testrunner/local/testsuite.py#newcode142
tools/testrunner/local/testsuite.py:142: (tmp0, tmp1, flags) =
outc.partition(':')
Suggestion: simplify the body of the if-block to:
t.flags += outcome[7:].split()
Have you tested this patch with the entire "mozilla" test suite? I think
you'd run into
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments
for t.flags. Suggested fix: change the default value in TestCase's
constructor to "flags=None", and the initialization line to "self.flags
= flags or []".
https://codereview.chromium.org/735723006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
