On 2014/11/19 13:57:15, Jakob wrote:
Have you tested this patch with the entire "mozilla" test suite? I think
you'd
run into
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments
for t.flags. Suggested fix: change the default value in TestCase's
constructor
to "flags=None", and the initialization line to "self.flags = flags or
[]".
Thank you for the fixes. I am not a python expert :) After fixing
flags=None I
run mozilla
tests for arm 64 and mips64el archs and all the tests are passed.
https://codereview.chromium.org/735723006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
