lgtm with a comment: You can also hit the CQ - then I'll do a refactoring
of the
code afterwards.
https://codereview.chromium.org/735723006/diff/20001/tools/testrunner/local/testsuite.py
File tools/testrunner/local/testsuite.py (right):
https://codereview.chromium.org/735723006/diff/20001/tools/testrunner/local/testsuite.py#newcode139
tools/testrunner/local/testsuite.py:139: for outcome in t.outcomes:
I'd rather put this code into a new method/loop right after the call
side of this method:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/tools/run-tests.py&q=v8/tools/run-t&sq=package:chromium&l=521
This method should be refactored anyway - lets restrict its concern to
filtering and outcomes definition - not also flags.
The code piece above currently only applies to "if testname in
self.rules" and not to the condition about wildcards below. But the
feature should also be available for wildcard rules I guess?
https://codereview.chromium.org/735723006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
