On 2014/12/08 at 10:32:55, rossberg wrote:
On 2014/12/07 15:21:59, Diego Pino wrote:
> This patch was pending to land after M40 branching. Perhaps it's
necessary
to
> review it again. Thanks!
After a recent emergencies we had with a harmless new feature causing web
breakage, I'm even more concerned shipping this without a flag. Here is a
suggestion:
- Instead of calling ToLength directly, call a new helper ToLengthFlagged.
- By default, this just invokes TO_UINT32.
- In harmony-arrays.js, it gets patched to ToLength.
This way, the new behaviour is only turned on with the --harmony-arrays
flag.
Also, make sure to have some tests for both the old and the new behaviour.
Does that make sense?
ToLength is an order of magnitude less scary than Array.prototype.values and
String.prototype.contains. I don't think it warrants this kind of caution.
https://codereview.chromium.org/553623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
