On 2014/12/10 14:52:54, rossberg wrote:
On 2014/12/10 14:22:14, caitp wrote:

> Try `var ToLengthFlagged = ToUint32;` in array.js, and `ToLengthFlagged =
> ToLength;` in harmony-array.js
>
> That should avoid the problem

Right, that's what I had in mind. Could you try that?

I tried to reduce the scope of the change and created a small patch on top of
ToT. This new version didn't work either. Here's the gist
https://gist.github.com/dpino/61b06a6b03a71070906a.

And here's the crash I got. This time I built with Clang.

+ exec make console=readline disassembler=on objectprint=on verifyheap=on
extrachecks=on gdbjit=on deprecationwarnings=on werror=no -j4 x64.release
make[1]: Entering directory `/home/dpino/workspace/v8/out'
  ACTION tools_gyp_v8_gyp_js2c_target_js2c
/home/dpino/workspace/v8/out/x64.release/obj/gen/libraries.cc
  ACTION tools_gyp_v8_gyp_js2c_target_js2c_experimental
/home/dpino/workspace/v8/out/x64.release/obj/gen/experimental-libraries.cc
  CXX(target)
/home/dpino/workspace/v8/out/x64.release/obj.target/v8_nosnapshot/gen/libraries.o
  CXX(target)
/home/dpino/workspace/v8/out/x64.release/obj.target/v8_nosnapshot/gen/experimental-libraries.o
  AR(target)
/home/dpino/workspace/v8/out/x64.release/obj.target/tools/gyp/libv8_nosnapshot.a
  LINK(target) /home/dpino/workspace/v8/out/x64.release/mksnapshot
  ACTION tools_gyp_v8_gyp_v8_snapshot_target_run_mksnapshot
/home/dpino/workspace/v8/out/x64.release/obj.target/v8_snapshot/geni/snapshot.cc
Exception thrown during bootstrapping
Extension or internal compilation error.
Failing script:
    1:

#
# Fatal error in ../src/mksnapshot.cc, line 143
# CHECK(blob.data) failed
#

==== C stack trace ===============================

 1: ??
 2: ??
 3: __libc_start_main
 4: ??
Illegal instruction (core dumped)
make[1]: ***
[/home/dpino/workspace/v8/out/x64.release/obj.target/v8_snapshot/geni/snapshot.cc]
Error 132
make[1]: Leaving directory `/home/dpino/workspace/v8/out'
make: *** [x64.release] Error 2

https://codereview.chromium.org/553623004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to